Reenable the config wizard but flag the stepper #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okta tests are failing unrelated to this PR except that this PR makes it visible in CI since the cypress test has been reenabled. captured here: #1837 |
We need to return undefined if the systems are still loading so that we don't get redirected right away.
allisonking
commented
Nov 21, 2022
LKCSmith
approved these changes
Nov 22, 2022
Merged
12 tasks
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
LJ-304
|
| Run status |
|
| Run duration | 00m 47s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 53s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1825
Code Changes
Re-enable the config wizard flag
Put the stepper component behind a flag
Replace the 'Config Wizard' nav link with 'Add Systems'
Change the url for
/config-wizardto/add-systems*See Enable config wizard with some caveats #1825 (comment) for some musings about this
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
Screen.Recording.2022-11-21.at.4.45.52.PM.mov