Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat response from adobe jwt appropriately, as milliseconds #1754

Merged
merged 2 commits into from
Nov 14, 2022
Merged

treat response from adobe jwt appropriately, as milliseconds #1754

merged 2 commits into from
Nov 14, 2022

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Nov 11, 2022 •
edited
Loading

Closes #1753

Code Changes

correct treatment of expires_in in adobe JWT response as milliseconds value, not seconds.

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@adamsachs adamsachs linked an issue Nov 11, 2022 that may be closed by this pull request
adobe auth strategy treats ms expiration duration as seconds #1753
Closed
galvana
galvana approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@adamsachs adamsachs merged commit 4408279 into main Nov 14, 2022
@adamsachs adamsachs deleted the 1753-adobe-auth-strategy-treats-ms-expiration-duration-as-seconds branch November 14, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adobe auth strategy treats ms expiration duration as seconds
2 participants
@adamsachs @galvana