Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adobe auth strategy treats ms expiration duration as seconds #1753

Closed
adamsachs opened this issue Nov 11, 2022 · 0 comments · Fixed by #1754
Closed

adobe auth strategy treats ms expiration duration as seconds #1753

adamsachs opened this issue Nov 11, 2022 · 0 comments · Fixed by #1754
Assignees
Labels
bug Something isn't working

Comments

@adamsachs
Copy link
Contributor

adamsachs commented Nov 11, 2022

Bug Description

in our adobe auth override, we're mistakenly treating the expires_in value we get from the adobe jwt exchange API response as if it were a seconds duration. in reality, it's a milliseconds duration, so we should treat it accordingly.

Steps to Reproduce

  1. run a DSR that uses the adobe connector. it will retrieve and store a temporary auth key in our app db.
  2. with same auth config (i.e. don't reset your db), run another DSR that uses the same adobe connector, more than 24 hours after step 1.
  3. you should hit an auth error (401) coming from adobe in your DSR execution. the token has expired, but our app will think it's still valid (since it thought it was expiring in 999 days, not .99 😄 )

Expected behavior

we should be refreshing and getting a new token when the existing token actually expires, i.e. what seems to be .99 days after it was created. in any case, it's expressed in ms, so as long as we handle that properly, we will be refreshing when we need to!

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version:
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.

@adamsachs adamsachs added the bug Something isn't working label Nov 11, 2022
@adamsachs adamsachs self-assigned this Nov 11, 2022
@adamsachs adamsachs linked a pull request Nov 11, 2022 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant