Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1637] api/permissions: Allow the root user to query their own permissions #1698

Merged
merged 3 commits into from
Nov 5, 2022

Conversation

ssangervasi
Copy link
Contributor

Closes #1637

Code Changes

  • Allow the root user to query their own permissions.
  • Test fixtures root user!

Steps to Confirm

  • Log in as root_user
  • The root user doesn't show up in user management (it's not a record)

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

The special-casing of root_user goes all the way into fideslib. This solves our login problem, and my change to get_current_user may prove helpful, but this will probably continue to be weird.

root-user-login.mp4

@ssangervasi ssangervasi merged commit 0aabd2f into main Nov 5, 2022
@ssangervasi ssangervasi deleted the ssangervasi/fides-1637/root-user branch November 5, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restore access to root_user
2 participants