Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that oauth root client can perform all API actions #1852

Closed
adamsachs opened this issue Nov 23, 2022 · 2 comments
Closed

Ensure that oauth root client can perform all API actions #1852

adamsachs opened this issue Nov 23, 2022 · 2 comments

Comments

@adamsachs
Copy link
Contributor

adamsachs commented Nov 23, 2022

Is your feature request related to a specific problem?

While the root oauth client is technically able to invoke all API endpoints, there are some db constraints/oddities that prevent the client from effectively being able to perform the API actions. The root client should be able to effectively use all of our APIs.

One notable instance of this is that the root client is unable to update the default DSR access policy (or any policy?) rule, i.e. using the PATCH /api/v1/dsr/poilcy/default_accesss_policy/rule endpoint. In this case, a 500 is returned with this underlying exception: ForeignKeyViolation('insert or update on table "rule" violates foreign key constraint "rule_client_id_fkey"\nDETAIL: Key (client_id)=(fidesadmin) is not present in table "client".\n')

#1698 was another instance of the problem that has already been resolved.

There may be (likely are) more instances of this problem, so we should try to identify and fix them all.

Describe the solution you'd like

  • Fix whatever DB constraints are preventing the root client from being able to perform an API action.

Describe alternatives you've considered, if any

Additional context

  • We hit this issue when walking through steps for a client deployment, and attempting to complete them as the root client
  • cc @NevilleS
@NevilleS
Copy link
Contributor

Thanks for writing this up @adamsachs - this is a footgun that'll sneak up on us in other places too, so I'd like to understand how difficult this would be to tackle

@adamsachs
Copy link
Contributor Author

adamsachs commented Jan 31, 2023

wanted to bump this for prioritization as it's come up multiple times in the wild, most recently for @nicolas-ethyca on a presales effort. specifically - updating policies and rules is table-stakes functionality for our app, we currently tend to use the oauth root user for most of our setup, and the workaround is pretty cumbersome. so this has a pretty big impact.

cc @Kelsey-Ethyca @mfbrown @NevilleS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants