Refactor to use common system table and column dropdown #1590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #879
Code Changes
ColumnDropdown
andSystemsCheckboxTable
to this repofidesui
, but I'm trying to stay unblocked so copied and pasted for now. https://github.com/ethyca/fidesui/pull/27 puts those components infidesui
, but it's awaiting review and some discussionfidesui
and things should Just WorkColumnDropdown
component and use the new one (used by DatasetFieldsTable and DatasetCollectionView). These should look and behave the same as beforeScanResultsForm
to use the newSystemsCheckboxTable
. This should also look mostly the same as beforeSteps to Confirm
flags.json
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Closely related to https://github.com/ethyca/fidesui/pull/27
Screen.Recording.2022-10-28.at.2.48.12.PM.mov