-
Notifications
You must be signed in to change notification settings - Fork 72
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor to use common system table and column dropdown (#1590)
* Refactor to use common ColumnDropdown component * Add common SystemsCheckboxTable * Use SystemsCheckboxTable in ScanResultsForm * Configure columns * Fix styling to allow for larger table * Update changelog * Fix padding on SuccessPage
- Loading branch information
1 parent
bdb8773
commit 819ebf7
Showing
10 changed files
with
311 additions
and
240 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149 changes: 149 additions & 0 deletions
149
clients/admin-ui/src/features/common/SystemsCheckboxTable.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| import { | ||
| Box, | ||
| Checkbox, | ||
| Table, | ||
| TableHeadProps, | ||
| Tbody, | ||
| Td, | ||
| Text, | ||
| Th, | ||
| Thead, | ||
| Tr, | ||
| } from "@fidesui/react"; | ||
|
|
||
| import type { ColumnMetadata } from "~/features/common/ColumnDropdown"; | ||
| import { System } from "~/types/api"; | ||
|
|
||
| /** | ||
| * Index into an object with possibility of nesting | ||
| * | ||
| * Ex: | ||
| * obj = { | ||
| * a : { | ||
| * b: 'hi' | ||
| * } | ||
| * } | ||
| * resolvePath(obj, 'a') --> { b: 'hi' } | ||
| * resolvePath(obj, 'a.b') --> 'hi' | ||
| * | ||
| * @param object The object to index into | ||
| * @param path String path to use as a key | ||
| * @returns | ||
| */ | ||
| export const resolvePath = (object: Record<string, any>, path: string) => | ||
| path.split(".").reduce((o, p) => (o ? o[p] : undefined), object); | ||
|
|
||
| // This component is used within a Chakra Td element. Chakra requires a | ||
| // JSX.Element in that context, so all returns in this component need to be wrapped in a fragment. | ||
| /* eslint-disable react/jsx-no-useless-fragment */ | ||
| const SystemTableCell = ({ | ||
| system, | ||
| attribute, | ||
| }: { | ||
| system: System; | ||
| attribute: string; | ||
| }) => { | ||
| if (attribute === "name") { | ||
| return ( | ||
| <label htmlFor={`checkbox-${system.fides_key}`}>{system.name}</label> | ||
| ); | ||
| } | ||
| if (attribute === "fidesctl_meta.resource_id") { | ||
| return ( | ||
| <Box | ||
| whiteSpace="nowrap" | ||
| overflow="hidden" | ||
| textOverflow="ellipsis" | ||
| title={system.fidesctl_meta?.resource_id} | ||
| > | ||
| {system.fidesctl_meta?.resource_id} | ||
| </Box> | ||
| ); | ||
| } | ||
| return <>{resolvePath(system, attribute)}</>; | ||
| }; | ||
|
|
||
| interface Props { | ||
| onChange: (systems: System[]) => void; | ||
| allSystems: System[]; | ||
| checked: System[]; | ||
| columns: ColumnMetadata<System>[]; | ||
| tableHeadProps?: TableHeadProps; | ||
| } | ||
| export const SystemsCheckboxTable = ({ | ||
| allSystems, | ||
| checked, | ||
| onChange, | ||
| columns, | ||
| tableHeadProps, | ||
| }: Props) => { | ||
| const handleChangeAll = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| if (event.target.checked) { | ||
| onChange(allSystems); | ||
| } else { | ||
| onChange([]); | ||
| } | ||
| }; | ||
| const onCheck = (system: System) => { | ||
| const exists = checked.indexOf(system) >= 0; | ||
| if (!exists) { | ||
| onChange([...checked, system]); | ||
| } else { | ||
| onChange(checked.filter((c) => c.fides_key !== system.fides_key)); | ||
| } | ||
| }; | ||
|
|
||
| const allChecked = allSystems.length === checked.length; | ||
|
|
||
| if (columns.length === 0) { | ||
| return <Text>No columns selected to display</Text>; | ||
| } | ||
|
|
||
| return ( | ||
| <Table | ||
| size="sm" | ||
| /* https://github.com/chakra-ui/chakra-ui/issues/6822 */ | ||
| sx={{ | ||
| tableLayout: "fixed", | ||
| }} | ||
| > | ||
| <Thead {...tableHeadProps}> | ||
| <Tr> | ||
| <Th width="15px"> | ||
| <Checkbox | ||
| colorScheme="complimentary" | ||
| title="Select All" | ||
| isChecked={allChecked} | ||
| onChange={handleChangeAll} | ||
| /> | ||
| </Th> | ||
| {columns.map((c) => ( | ||
| <Th key={c.attribute}>{c.name}</Th> | ||
| ))} | ||
| </Tr> | ||
| </Thead> | ||
| <Tbody> | ||
| {allSystems.map((system) => ( | ||
| <Tr key={system.fides_key}> | ||
| <Td> | ||
| <Checkbox | ||
| colorScheme="complimentary" | ||
| value={system.fides_key} | ||
| isChecked={checked.indexOf(system) >= 0} | ||
| onChange={() => onCheck(system)} | ||
| data-testid={`checkbox-${system.fides_key}`} | ||
| /> | ||
| </Td> | ||
| {columns.map((c) => ( | ||
| <Td key={c.attribute}> | ||
| <SystemTableCell system={system} attribute={c.attribute} /> | ||
| </Td> | ||
| ))} | ||
| </Tr> | ||
| ))} | ||
| </Tbody> | ||
| </Table> | ||
| ); | ||
| }; | ||
|
|
||
| export default SystemsCheckboxTable; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.