Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bulk restart from failure endpoint #1470

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Add bulk restart from failure endpoint #1470

merged 3 commits into from
Oct 24, 2022

Conversation

sanders41
Copy link
Contributor

Closes #1225

Code Changes

  • Added bulk restart privacy request from failure endpoint.

Steps to Confirm

  • New tests added to test suite

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@sanders41 sanders41 marked this pull request as ready for review October 17, 2022 23:18
@sanders41 sanders41 changed the title Add bulk restart from failure endpoint endpoint Add bulk restart from failure endpoint Oct 17, 2022
This was referenced Oct 18, 2022
Closed
Merged
adamsachs
adamsachs approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, changes seem straightforward enough - you've kept things DRY - and the test coverage looks solid.

only thing is the merge conflict now with the doordash changes - probably at least partially my fault for getting to this review so late!

@sanders41
Copy link
Contributor Author

These tests started failing after merging main and are unrelated to any changes in this PR. It looks like they are failing on all PRs. So far I have been unable to get it to fail when running locally to troubleshoot.

@chriscalhoun1974 chriscalhoun1974 merged commit 6e76b1b into main Oct 24, 2022
@chriscalhoun1974 chriscalhoun1974 deleted the ps-bulk-reprocess branch October 24, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoint for Bulk select and reprocess DSRs
3 participants
@sanders41 @adamsachs @chriscalhoun1974