Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsr error handling reprocess #1489

Merged
merged 33 commits into from
Oct 26, 2022
Merged

Conversation

chriscalhoun1974
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Oct 19, 2022

Closes #1203 #1205

Code Changes

  • Added checkbox column header to the Subject Requests landing page to support multi-select DSR Error status requests to be submitted for reprocessing
  • When checkbox column header is clicked, toggles all DSR request(s) with a status of Error checkbox to true/false
  • Reprocess button is displayed via upper right hand corner when at least one or more DSR request(s) are checked
  • If one or more DSR Error requests are selected and user proceeds to click the Reprocess button, the API endpoint (/api/v1/privacy-request/bulk/retry) will be invoked. As a result, a toast notification of success or error is displayed. DSR requests which are reprocessed successfully will now have a status of In Progress. If the DSR requests which failed during reprocessing will still have a status of Error. After the API endpoint has returned a response the Subject Requests result set is reloaded.
  • Ability to allow a user to reprocess a given DSR request of Error status individually by hovering and clicking the Reprocess button on a given Subject Requests table row.
  • Renamed the Retry button to Reprocess located on the Subject Request Detail page. This can be accessed by the user by clicking the View Details menu item from the hamburger menu.

Steps to Confirm

  1. Create a new PostgreSQL Database connection via Fides Admin UI.
  2. Click the Create new connection button via the Datastore Connections landing page.
  3. Click the PostgreSQL card
  4. On the Connector parameters step, enter the following required fields: Name, Connection Identifier, and Url [Enter a bad URL value)
  5. Click the Save button
  6. Enter a valid sytem yaml value and click the Save yaml system button (Copy and paste the data > dataset > postgres_example_test_dataset.yml file contents minus the first line)
  7. Login to the Privacy Center web app
  8. Click the Access your data card
  9. Enter the Name and Email fields only and click the Continue button
  10. Login back to the Fides Admin UI web app
  11. Find the new DSR request created with an Error status
  12. Click the Datastore Connections link and delete the PostgreSQL Database connection you created in step 1 above
  13. Click the Subject Requests link and select the checkbox of the new DSR request with an Error status in step 11.
  14. Locate and click the Reprocess button displayed in the upper right hand corner
  15. Successful/error toast notification is rendered
  16. Your DSR request now has a Completed status

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

Screen Shots

Screen Shot 2022-10-19 at 10 45 47 AM
Screen Shot 2022-10-19 at 10 46 38 AM
Screen Shot 2022-10-19 at 10 47 45 AM
Screen Shot 2022-10-19 at 6 16 10 PM

@chriscalhoun1974 chriscalhoun1974 marked this pull request as draft October 19, 2022 13:23
@chriscalhoun1974
Copy link
Contributor Author

@Kelsey-Ethyca If the bulk retry batch fails, do you think the UI should uncheck all of the originally selected items? If the bulk retry batch is successful but one or more DSRs fail, then the originally selected items will be all unchecked and result set refreshes displaying the new in processing statuses accordingly.

Copy link
Contributor

@ssangervasi ssangervasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be going on vacation, so approving with just that one comment left.

@chriscalhoun1974 chriscalhoun1974 merged commit 8766056 into main Oct 26, 2022
@chriscalhoun1974 chriscalhoun1974 deleted the dsr-error-handling-reprocess branch October 26, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individually select and reprocess DSRs that have errored
3 participants