-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1204 - Configure Connector after creation #1356
Merged
chriscalhoun1974
merged 21 commits into
main
from
1204---Configure-Connector-after-creation
Oct 17, 2022
Merged
1204 - Configure Connector after creation #1356
chriscalhoun1974
merged 21 commits into
main
from
1204---Configure-Connector-after-creation
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscalhoun1974
changed the title
1024 - Configure Connector after creation
1204 - Configure Connector after creation
Oct 11, 2022
chriscalhoun1974
requested review from
LKCSmith,
ssangervasi and
Kelsey-Ethyca
October 11, 2022 15:08
ssangervasi
reviewed
Oct 12, 2022
ssangervasi
reviewed
Oct 12, 2022
clients/admin-ui/src/features/datastore-connections/add-connection/sass/ConnectorParameters.tsx
Outdated
Show resolved
Hide resolved
ssangervasi
reviewed
Oct 12, 2022
ssangervasi
reviewed
Oct 12, 2022
ssangervasi
reviewed
Oct 12, 2022
clients/admin-ui/src/features/datastore-connections/edit-connection/EditConnection.tsx
Show resolved
Hide resolved
…statements Added the following rules to enforce curly braces for all control statements - " curly": ["error", "all"], - "nonblock-statement-body-position": ["error", "below"]
LKCSmith
suggested changes
Oct 14, 2022
clients/admin-ui/src/features/datastore-connections/ConnectionGridItem.tsx
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/ConnectionsContainer.tsx
Show resolved
Hide resolved
LKCSmith
approved these changes
Oct 17, 2022
chriscalhoun1974
deleted the
1204---Configure-Connector-after-creation
branch
October 17, 2022 17:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1204
Code Changes
/datastore-connection/[id]
) for when the user clicks the Configure option, the browser window will navigate to a new URL such ashttp://localhost:3000/datastore-connection/my_manual_webhook_1
Steps to Confirm
Create New Connection
and complete the create connection workflowConfigure
optionhttp://localhost:3000/datastore-connection/my_manual_webhook_1
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
NOTE: Currently if a user were to select an option from the Datastore Type dropdown which is a Saas connector type, the API does not support this filtering feature at this time. In addition, if a user were to click the Manual connectors option from the the System Type dropdown, the API does not support this filtering feature as well. Experience Team will address this issue in the next upcoming sprint.