Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1204 - Configure Connector after creation #1356

Merged
merged 21 commits into from
Oct 17, 2022

Conversation

chriscalhoun1974
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Oct 10, 2022

Closes #1204

Code Changes

  • Configure option has been added to the hamburger menu for each connection listed on the Datastore Connections landing page
  • New route has been configured (/datastore-connection/[id]) for when the user clicks the Configure option, the browser window will navigate to a new URL such as http://localhost:3000/datastore-connection/my_manual_webhook_1
  • Datastore Type and System Type dropdown menus have been updated on the Datastore Connections landing page to mirror the Choose your connection page
  • Set focus to Username input text box on login page and added autocomplete="off" attribute to Username and Password input text boxes

Steps to Confirm

  1. Login to Fides Admin UI
  2. Click the Datastore Connections link
  3. If no connection(s) exist, click Create New Connection and complete the create connection workflow
  4. If connection(s) exist, click the hamburger menu item and select the Configure option
  5. Browser window will navigate to a URL such as http://localhost:3000/datastore-connection/my_manual_webhook_1
  6. User can edit values for a given Manual, Database, or 3rd party integrations connector connection (Connector parameters, Dataset configuration, or DSR customization screens)

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

NOTE: Currently if a user were to select an option from the Datastore Type dropdown which is a Saas connector type, the API does not support this filtering feature at this time. In addition, if a user were to click the Manual connectors option from the the System Type dropdown, the API does not support this filtering feature as well. Experience Team will address this issue in the next upcoming sprint.

Screen Shot 2022-10-10 at 9 27 00 PM
Screen Shot 2022-10-10 at 9 27 49 PM
Screen Shot 2022-10-10 at 9 51 06 PM
Screen Shot 2022-10-10 at 9 51 19 PM
Screen Shot 2022-10-10 at 9 54 58 PM

@chriscalhoun1974 chriscalhoun1974 requested a review from a team October 10, 2022 17:27
@chriscalhoun1974 chriscalhoun1974 marked this pull request as draft October 10, 2022 17:27
@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review October 11, 2022 02:10
@chriscalhoun1974 chriscalhoun1974 changed the title 1024 - Configure Connector after creation 1204 - Configure Connector after creation Oct 11, 2022
@chriscalhoun1974 chriscalhoun1974 requested a review from a team October 13, 2022 15:25
@chriscalhoun1974 chriscalhoun1974 merged commit 8917cad into main Oct 17, 2022
@chriscalhoun1974 chriscalhoun1974 deleted the 1204---Configure-Connector-after-creation branch October 17, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Connector after creation
4 participants