-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Connector after creation #1204
Comments
reach out to design to discuss this as a drawer to make the work easier and design more consistent |
Consider masking api keys so that the data can persist and not be removed when a user wants to simply edit the title. We can add a separate user story for this. |
FYI there are 2 separate endpoints to save 1. the name and other config 2. the secrets See PATCH /api/v1/connection and PUT /api/v1/connection/{connection_key}/secret We will likely need to update the second endpoint to a patch |
@mfbrown @Kelsey-Ethyca @renderbits @adamczepeda I have a few questions I would like to get some feedback. Please let me know if I should schedule a meeting to walkthrough each item .
NOTE: Currently, the UI makes 2 separate API calls from the FE to the BE to create a connection and save the config secrets. Each API call is mutually exclusive. My upcoming commit does NOT display a toast for a connection created if the config secrets fail to save.
NOTE: Currently, the user is auto redirected. Given the auto redirect the user cannot click the Test connection button for a Database or Saas connection on the Connector parameters screen after clicking the Save button initially. After the auto redirect the user can navigate manually to the Connector parameters form via left hand side navigation and click the Test connection button.
|
Here is the initial PR |
Backend work found in #1227
USER STORY
As an admin, I want to a be able to update a connector after creation.
AC
DESIGNS
https://www.figma.com/file/4qgQpYc1bX4dXg2PHmRORL/DSR-Error-Handling?node-id=88%3A4993
Extra Info
Epic Requirements Doc
The text was updated successfully, but these errors were encountered: