Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Connector after creation #1204

Closed
Kelsey-Ethyca opened this issue Oct 4, 2022 · 5 comments · Fixed by #1356
Closed

Configure Connector after creation #1204

Kelsey-Ethyca opened this issue Oct 4, 2022 · 5 comments · Fixed by #1356
Assignees

Comments

@Kelsey-Ethyca
Copy link
Contributor

Kelsey-Ethyca commented Oct 4, 2022

Backend work found in #1227

USER STORY

As an admin, I want to a be able to update a connector after creation.

AC

  • in the meatball menu for a connector in the Datastore Connections tab, add Configure option
  • reuse the connector's creation form pre-populated with the current data
  • fix the bug that throws an error when you hit save twice - aka allow for updates

DESIGNS

https://www.figma.com/file/4qgQpYc1bX4dXg2PHmRORL/DSR-Error-Handling?node-id=88%3A4993

Extra Info

Epic Requirements Doc

@Kelsey-Ethyca
Copy link
Contributor Author

reach out to design to discuss this as a drawer to make the work easier and design more consistent

@Kelsey-Ethyca
Copy link
Contributor Author

Kelsey-Ethyca commented Oct 4, 2022

Consider masking api keys so that the data can persist and not be removed when a user wants to simply edit the title. We can add a separate user story for this.

@Kelsey-Ethyca
Copy link
Contributor Author

Kelsey-Ethyca commented Oct 4, 2022

FYI there are 2 separate endpoints to save 1. the name and other config 2. the secrets

See PATCH /api/v1/connection and PUT /api/v1/connection/{connection_key}/secret

We will likely need to update the second endpoint to a patch

@chriscalhoun1974
Copy link
Contributor

chriscalhoun1974 commented Oct 10, 2022

@mfbrown @Kelsey-Ethyca @renderbits @adamczepeda I have a few questions I would like to get some feedback. Please let me know if I should schedule a meeting to walkthrough each item .

  1. When creating a DB connection should I display a toast informing the user that the connection was created if the config secrets fail to save?

NOTE: Currently, the UI makes 2 separate API calls from the FE to the BE to create a connection and save the config secrets. Each API call is mutually exclusive. My upcoming commit does NOT display a toast for a connection created if the config secrets fail to save.

  1. Should we auto redirect the user to the Dataset configuration or DSR customization form after the user clicks the Save button via the Connector parameters form upon creating a Manual, Database, or 3rd party integration (Says) connection type?

NOTE: Currently, the user is auto redirected. Given the auto redirect the user cannot click the Test connection button for a Database or Saas connection on the Connector parameters screen after clicking the Save button initially. After the auto redirect the user can navigate manually to the Connector parameters form via left hand side navigation and click the Test connection button.

  1. When editing a Manual connector connection, should the following statement be omitted?
To begin setting up your new Manual Webhook connector you must first assign a name to the connector and a description.
Please suggest additional verbiage if needed.
  1. On the Datastore Connections landing page if a given connection does not have a description supplied, should I create an empty placeholder within the given connection card?

Image
Image

@chriscalhoun1974
Copy link
Contributor

Here is the initial PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants