Classify data category dropdown #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonking
force-pushed
the
aking-1077-classify-data-category-dropdown
branch
from
85b3c71
to
36f532a
Compare
ssangervasi
reviewed
Sep 23, 2022
clients/ctl/admin-ui/src/features/dataset/ClassifiedDataCategoryDropdown.tsx
Outdated
Show resolved
Hide resolved
ssangervasi
reviewed
Sep 23, 2022
clients/ctl/admin-ui/src/features/dataset/ClassifiedDataCategoryDropdown.tsx
Show resolved
Hide resolved
ssangervasi
approved these changes
Sep 23, 2022
It is getting big, and it avoids circular dependencies
…onents accessing the store will still work
|
@ssangervasi after your question about the design, I decided to just integrate the component into the page (with a TODO for what the So that's a few extra commits, and would love if you could take one more look! |
ssangervasi
reviewed
Sep 27, 2022
clients/ctl/admin-ui/src/features/dataset/DataCategoryInput.tsx
Outdated
Show resolved
Hide resolved
|
Updated: Screen.Recording.2022-09-27.at.4.02.45.PM.mov |
ssangervasi
approved these changes
Sep 30, 2022
clients/ctl/admin-ui/src/features/dataset/ClassifiedDataCategoryDropdown.tsx
Outdated
Show resolved
Hide resolved
clients/ctl/admin-ui/src/features/dataset/ClassifiedDataCategoryDropdown.tsx
Show resolved
Hide resolved
clients/ctl/admin-ui/cypress/components/ClassifiedDataCategoryInput.cy.tsx
Show resolved
Hide resolved
* main: Restrict startsWith comparisons in CheckboxTree more (#1126) [1076] ui/plus: Approve dataset classification button (#1129) Do not rely on order for checking intercept results (#1131) Prepare 1.9.1 release (#1137) Bump fideslang to 1.3.1 (#1136) Prepare changelog for 1.9.0 release (#1134) Update CHANGELOG.md (#1132) Fix bug causing missing datamap rows (#1124) cls migration (#1060)
ssangervasi
force-pushed
the
aking-1077-classify-data-category-dropdown
branch
from
1d180d7
to
f6ab5ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual part of #1077 (not integrated yet)
Code Changes
DataCategoryInputto make it more reusableClassifiedDataCategoryInputwhich is two select boxes combinedSteps to Confirm
playgroundwhich will let you just play with the componentPre-Merge Checklist
CHANGELOG.mdDescription Of Changes
I thought I'd put up this PR up before attempting to integrate it into the app to make sure the behavior looks right. Given that https://github.com/ethyca/fidesctl-plus/issues/99 isn't in yet, can't integrate fully, but could perhaps get a little farther.
Screen.Recording.2022-09-22.at.2.38.08.PM.mov