Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset classification field in editor panel #1077

Closed
mfbrown opened this issue Sep 14, 2022 · 3 comments
Closed

Add dataset classification field in editor panel #1077

mfbrown opened this issue Sep 14, 2022 · 3 comments
Assignees

Comments

@mfbrown
Copy link

mfbrown commented Sep 14, 2022

  • Design: Fidesops-Management-UI (old)
  • When no category has been manually assigned, the selected category shows classifier's best category match.
  • Clicking on "search taxonomy" (left half) shows the original checkbox tree to manually set the categories.
  • Clicking on the selected categories area (right half) shows a dropdown with a list of the suggested categories and their confidence. Clicking on a suggested category selects it, just like selecting it from the checkbox tree.

❓Open questions:

  • Is there an API to assign set this field? Does it live on the dataset model? - This should ultimately be returned by this new endpoint I believe: https://github.com/ethyca/fidesctl-plus/issues/99
  • What even is this? - _This is the list of classification suggestions which were generated for the field. Classify will often return more than one suggestion and we want to give users the option to review and select from them if necessary. (Note: this question was asked when the design had the "classification" separate from the category dropdown. It should be clear now.)
@ssangervasi
Copy link
Contributor

Note: this ticket can cover updating the visual changes and selection state without worrying about how the data comes from the API. When the API is ready I'll transform the result into whatever is convenient for this interface.

@allisonking allisonking self-assigned this Sep 21, 2022
@allisonking
Copy link
Contributor

@mfbrown can you confirm if the output of this glorified select multi-box is a single value, or an array of values? the left side (checkbox tree) gives an array at the moment, but the right side looks more like a single select? if someone chooses something from the right side, does that remove anything chosen by the left? or is it always adding?

@allisonking
Copy link
Contributor

We've decided that we will output arrays, and the box on the right will be a multiselect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants