Update limit for L2 #112
Merged
Update limit for L2 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qizhou
reviewed
Oct 8, 2024
qzhodl
reviewed
Oct 8, 2024
qzhodl
approved these changes
Oct 9, 2024
ping-ke
reviewed
Oct 10, 2024
ping-ke
reviewed
Oct 10, 2024
ping-ke
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #36 using a rate limit for updating on L2 contract.
The value of the limit is evaluated in the following tests:
Deploy a test storage contract on an L2 network with 8192 entries per shard. Set up an RPC es-node as a bootstrap node and download a full shard containing 8192 uploaded blobs.
Afterward, start another es-node, connect it to the bootstrap node, and observe the synchronization process fully utilizing the CPU cores.
Finally, note the time taken and the number of blobs synchronized according to logs.
The test results of 3 times syncs are 46, 40, and 49 separately, 45 on average.
As the block interval is 2 on L2 we set
UPDATE_LIMITas 45*2 = 90.Tests with an L2 contract using a modified version of sdk to update over
UPDATE_LIMITwith the same key, failed withexceeds update rate limit.