Track prepaid amount and withdraw treasury #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhodl
reviewed
Sep 19, 2024
qzhodl
reviewed
Sep 23, 2024
Co-authored-by: Qiang Zhu <[email protected]>
ping-ke
reviewed
Sep 24, 2024
qzhodl
reviewed
Sep 26, 2024
Closed
qzhodl
approved these changes
Sep 26, 2024
ping-ke
approved these changes
Sep 27, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #54.
As discussed offline, we need a variable to track the total prepaid amount, and a withdrawal method to transfer the extra treasury as much as the fund meets the prepaid requirement.
The unit tests cover the case where the prepaid amount is capped when rewarding miners, which should be part of treasury.