contracts-bedrock: add some view functions to FaultDisputeGameN #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 1, 2024 20:53
… branch variable to uint256, to unify with other variable types.
|
Why attack branch variable's type need to be unify with other variable types? |
When calling in Go language, there is no need to handle different data types. |
dajuguan
changed the title
qizhou
pushed a commit
that referenced
this pull request
Oct 29, 2024
* chore: rename isthmus to interop on solidity files * chore: rename test file * chore: update contracts versions (#66)
dajuguan
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support op-challenger's functionality, this PR slightly modified
FaultDisputeGameN.sol:nBitsandmaxAttackBranchview functions in FaultDisputeGameNRegression tests
forge test --mc FaultDisputeGameN_Test
forge test --mc FaultDisputeN_1v1_Actors_Test