evm: ensure modexp right-pads input data #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
force-pushed
the
fix-precompiles-inputs
branch
from
c55eb46 to
05b70b0
Compare
|
Rebased this via UI |
|
Tests failing, not sure what happened (simply haven’t looked). |
|
Hmm the modexp tests on blockchain/state are failing so that's interesting, I thought this fix would be somewhat trivial 🤔 |
…umjs-monorepo into fix-precompiles-inputs
acolytec3
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3204
I have reviewed EVM to see if there are more cases of doing "not-safe-slices" of any input. The only other candidate which could have impact which I could find are the ECMUL and ECADD precompiles. We should investigate this. (To be addressed in another PR).