evm: ensure modexp right-pads input data

ethereumjs · Dec 19, 2023 · 05b70b0 · 05b70b0
1 parent c5054eb
commit 05b70b0
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 13 deletions.
diff --git a/packages/evm/src/precompiles/05-modexp.ts b/packages/evm/src/precompiles/05-modexp.ts
@@ -103,7 +103,7 @@ export function expmod(a: bigint, power: bigint, modulo: bigint) {
 }
 
 export function precompile05(opts: PrecompileInput): ExecResult {
-  const data = opts.data
+  const data = setLengthRight(opts.data, 96)
 
   let adjustedELen = getAdjustedExponentLength(data)
   if (adjustedELen < BIGINT_1) {

diff --git a/packages/evm/test/precompiles/05-modexp.spec.ts b/packages/evm/test/precompiles/05-modexp.spec.ts
@@ -15,18 +15,31 @@ describe('Precompiles: MODEXP', () => {
   const addressStr = '0000000000000000000000000000000000000005'
   const MODEXP = getActivePrecompiles(common).get(addressStr)!
 
-  let n = 0
-  for (const [input, expect] of fuzzerTests) {
-    n++
-    it(`MODEXP edge cases (issue 3168) - case ${n}`, async () => {
-      const result = await MODEXP({
-        data: hexToBytes(input),
-        gasLimit: BigInt(0xffff),
-        common,
-        _EVM: evm,
+  it('should run testdata', async () => {
+    let n = 0
+    for (const [input, expect] of fuzzerTests) {
+      n++
+      it(`MODEXP edge cases (issue 3168) - case ${n}`, async () => {
+        const result = await MODEXP({
+          data: hexToBytes(input),
+          gasLimit: BigInt(0xffff),
+          common,
+          _EVM: evm,
+        })
+        const oput = bytesToHex(result.returnValue)
+        assert.equal(oput, expect)
       })
-      const oput = bytesToHex(result.returnValue)
-      assert.equal(oput, expect)
+    }
+  })
+
+  it.only('should correctly right-pad data if input length is too short', async () => {
+    const gas = BigInt(0xffff)
+    const result = await MODEXP({
+      data: hexToBytes('0x41'),
+      gasLimit: gas,
+      common,
+      _EVM: evm,
     })
-  }
+    assert.ok(result.executionGasUsed === gas)
+  })
 })