Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo/Util: deprecate node 16 / remove Node.js fetch primitive #2859

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

gabrocheleau
Copy link
Contributor

Resolves #2850

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2859 (959f728) into master (5f8552f) will decrease coverage by 9.81%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
client ?
vm 77.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau
Copy link
Contributor Author

To get the CI to pass, someone with the relevant repository permissions would need to update the "required workflows" so that they look for the node18 tests rather than the node16 ones.

@acolytec3
Copy link
Contributor

Can you also update the test in provider.spec.ts to remove the check for global fetch?

@gabrocheleau
Copy link
Contributor Author

Can you also update the test in provider.spec.ts to remove the check for global fetch?

ah yes good point, done!

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling, also for doing this so thoroughly with all the additional clean-ups and findings (resetting the engines property in package.json is a great and important one e.g.)!

LGTM, have adjusted CI and will merge.

@holgerd77 holgerd77 changed the title monorepo: deprecate node 16 monorepo/Util: deprecate node 16 / remove Node.js fetch primitive Jul 5, 2023
@holgerd77 holgerd77 merged commit ef133de into master Jul 5, 2023
@holgerd77 holgerd77 deleted the monorepo/deprecate-node-16 branch July 5, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment