-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monorepo/Util: deprecate node 16 / remove Node.js fetch primitive #2859
Conversation
To get the CI to pass, someone with the relevant repository permissions would need to update the "required workflows" so that they look for the node18 tests rather than the node16 ones. |
Can you also update the test in |
ah yes good point, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling, also for doing this so thoroughly with all the additional clean-ups and findings (resetting the engines
property in package.json
is a great and important one e.g.)!
LGTM, have adjusted CI and will merge.
Resolves #2850