Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util/Monorepo: Deprecate Node 16 / Switch to native fetch() in Util #2850

Closed
holgerd77 opened this issue Jul 3, 2023 · 0 comments · Fixed by #2859
Closed

Util/Monorepo: Deprecate Node 16 / Switch to native fetch() in Util #2850

holgerd77 opened this issue Jul 3, 2023 · 0 comments · Fixed by #2859

Comments

@holgerd77
Copy link
Member

This is a follow-up more specific issue to #2837 , will close the old one.

We have got one single Node.js primitive usage left we want to get rid off, which is the usage of the https package for the fetch implementation in the Util provider.ts package.

For this we decided the following in one of the last calls: Node.js 18 introduces native fetch. We will therefore deprecate (in the sense of: remove) support for Node 16 on this occasion, which only has extended support for a very few months left anyhow, which will the free us to use native fetch in the Util provider module to replace the Node native stuff.

This should be done. 🙂

The PR should also make sure that CI/Actions is not run on Node 16 any more (then go to Node 18 I would say?), particularly in the Node versions tests Node 16 should be removed.

Update: just did a simple "16" search in the /.github folder, actually there are a lot of references to Node 16 which can either get updated or on several occasions I think would also just lead to a clean-up/deletion of code parts (if there are conditionals around Node 16 e.g.).

@holgerd77 holgerd77 changed the title Util/Monorepo: Deprecate Node 16 / Switch to native tech in Util Util/Monorepo: Deprecate Node 16 / Switch to native fetch() in Util Jul 3, 2023
@gabrocheleau gabrocheleau self-assigned this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants