You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I played a lot with bundlers today (Rollup, Parcel, Vite), and where these constantly have problems are our remaining Node.js primitives.
So Rollup was breaking in Util already, using the https Node module for the fetcher, Vite in EVM using Node.js native promisify.
I would therefore make a strong pledge that we remove these last remaining few Node.js primitive usages.
Will confirm below once I have them together, but from my impression no usage is life-critical here so we should consider to replace or in a worst case remove. Just not worth to sacrifice browser compatibility for some nice side functionality or performance gain.
So, following occurrences:
'https' in Util.provider:
Replace or remove the functionality
'util.promisify' in EVM (evm.ts)
'util.promisify' in VM (vm.ts)
Replace or take performance loss into account (stated as "huge", would be good to have some numbers/relation here).
Ah, uh, yeah. Seems these are already the 2 left cases. Ok, this should be a some easy grasp.
The text was updated successfully, but these errors were encountered:
I played a lot with bundlers today (Rollup, Parcel, Vite), and where these constantly have problems are our remaining Node.js primitives.
So Rollup was breaking in Util already, using the
https
Node module for the fetcher, Vite in EVM using Node.js nativepromisify
.I would therefore make a strong pledge that we remove these last remaining few Node.js primitive usages.
Will confirm below once I have them together, but from my impression no usage is life-critical here so we should consider to replace or in a worst case remove. Just not worth to sacrifice browser compatibility for some nice side functionality or performance gain.
So, following occurrences:
'https' in
Util.provider
:Replace or remove the functionality
'util.promisify' in
EVM
(evm.ts
)'util.promisify' in
VM
(vm.ts
)Replace or take performance loss into account (stated as "huge", would be good to have some numbers/relation here).
Ah, uh, yeah. Seems these are already the 2 left cases. Ok, this should be a some easy grasp.
The text was updated successfully, but these errors were encountered: