Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Last Remaining Node.js Primitives #2837

Closed
holgerd77 opened this issue Jun 28, 2023 · 4 comments
Closed

Remove Last Remaining Node.js Primitives #2837

holgerd77 opened this issue Jun 28, 2023 · 4 comments

Comments

@holgerd77
Copy link
Member

I played a lot with bundlers today (Rollup, Parcel, Vite), and where these constantly have problems are our remaining Node.js primitives.

So Rollup was breaking in Util already, using the https Node module for the fetcher, Vite in EVM using Node.js native promisify.

I would therefore make a strong pledge that we remove these last remaining few Node.js primitive usages.

Will confirm below once I have them together, but from my impression no usage is life-critical here so we should consider to replace or in a worst case remove. Just not worth to sacrifice browser compatibility for some nice side functionality or performance gain.

So, following occurrences:

'https' in Util.provider:
Replace or remove the functionality

'util.promisify' in EVM (evm.ts)
'util.promisify' in VM (vm.ts)
Replace or take performance loss into account (stated as "huge", would be good to have some numbers/relation here).

Ah, uh, yeah. Seems these are already the 2 left cases. Ok, this should be a some easy grasp.

@jochem-brouwer
Copy link
Member

util.promisify is removed in #2835 (except that it is still in the RLP tests, but this should not be a problem for the bundlers (?))

@holgerd77
Copy link
Member Author

Yes, tests do not matter.

@holgerd77
Copy link
Member Author

Can confirm that it's removed for both EVM and VM.

@holgerd77
Copy link
Member Author

Closing in favor of #2850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants