Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monorepo: Add Browser Examples #2835

Merged
merged 20 commits into from
Jun 28, 2023
Merged

Monorepo: Add Browser Examples #2835

merged 20 commits into from
Jun 28, 2023

Conversation

holgerd77
Copy link
Member

Complements #2832

@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #2835 (f50cff5) into master (36aea11) will decrease coverage by 0.01%.
The diff coverage is 78.26%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.13% <ø> (ø)
blockchain 92.50% <ø> (ø)
client 87.10% <ø> (+0.01%) ⬆️
common 97.10% <ø> (ø)
devp2p 86.58% <ø> (ø)
ethash ∅ <ø> (∅)
evm 67.01% <80.00%> (+0.01%) ⬆️
rlp ?
statemanager 86.40% <70.00%> (+0.04%) ⬆️
trie 89.73% <ø> (-0.29%) ⬇️
tx 95.97% <ø> (ø)
util 85.93% <ø> (ø)
vm 77.10% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. Great addition!

@acolytec3 acolytec3 merged commit 71911d4 into master Jun 28, 2023
@holgerd77 holgerd77 deleted the add-browser-examples branch June 28, 2023 20:01
@jochem-brouwer jochem-brouwer mentioned this pull request Jun 28, 2023
Closed
@holgerd77
Copy link
Member Author

This is fantastic. Great addition!

Really happy that you like it so much! 🙂 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: block package: blockchain package: common package: mpt package: rlp package: statemanager package: tx package: util PR state: WIP type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerd77 @acolytec3