Async eth.get_balance, eth.get_code, eth.get_transaction_count #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
aeth-get-balance
branch
from
a1a7c43 to
5046361
Compare
kclowes
changed the title
fselmo
reviewed
Jul 20, 2021
| @@ -40,8 +40,6 @@ | |||
| from web3 import Web3 # noqa: F401 | |||
| from web3.module import Module # noqa: F401 | |||
|
|
|||
| Munger = Callable[..., Any] | |||
There was a problem hiding this comment.
Is this change just to simplify it a bit since this is pretty general anyhow?
There was a problem hiding this comment.
oops, I don't remember why I did this. Will put it back!
fselmo
approved these changes
Jul 20, 2021
kclowes
force-pushed
the
aeth-get-balance
branch
from
e625da0 to
b7e5f3d
Compare
|
my code w3.eth.get_code(account.address)) return b'' (empty) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Added async
eth.get_balance,eth.get_code, andeth.get_transaction_count(all methods that use theblock_id_munger).Related to Issue #1413
Todo:
Cute Animal Picture