-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web3 Async API Tracking Issue #1413
Comments
@kclowes I was thinking about taking on one of these Async additions if it didn't turn into a mountain of work. I had one question. On the Geth one above I see there is Admin, Miner, Personal, Shh, TxPool. I looked at the docs on how these methods are used. When I try to run inspect or status (see below code) in TxPool module I get Is the documentation wrong here or am I missing something
|
@dbfreem that error message is coming back from your node. You’ll need to be attached to a local Geth node to have access to those methods. Sometimes you also need a flag on startup to have access to those modules on the Geth side. Running ‘geth —help’ should show the commands you need. It don’t remember the exact command off the top of my head but it’s something like ‘—http.api=personal’ |
are all of the above outstanding tasks? |
I was looking at asyncing parity but noticed there are no test for it. What is the strategy for async on parity code? |
Copy/paste from #1161, but with checkboxes and slightly more granularity. These will likely become their own issues.
Replace api methods with instances of a Method class, with a middleware like layer for formatting/normalizing/validating method input/output.
Reduce middlewares to only those that make calls to the web3 api, moving the formatting middlewares to the Method input/output formatters.
Separate async and sync execution pathway through RequestManagers -> middlewares -> providers.
Parity PersonalParity ShhGeth ShhTestingThe text was updated successfully, but these errors were encountered: