Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typing-extensions imports to compatible version #1554

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Dec 17, 2019

What was wrong?

re @veox in the web3 gitter channel - typing_extensions was incorrectly used instead of the imported version from web3._utils.compat

Todo:

Cute Animal Picture

image

@njgheorghita njgheorghita marked this pull request as ready for review December 17, 2019 09:01
@njgheorghita njgheorghita requested a review from kclowes December 17, 2019 09:01
@veox
Copy link
Contributor

veox commented Dec 17, 2019

I've detected this by running ipython and then import web3 (or from web3.auto import w3) with a clean-room Python 3.8 install (via pip install -e .).

It resulted in

<long traceback snipped>
~/src/web3.py/web3/_utils/transactions.py in <module>
     17     HexBytes,
     18 )
---> 19 from typing_extensions import (
     20     Literal,
     21 )

Is there a test case for this?.. It would probably happen without ipython, too, with plain:

% python -c 'from web3.auto import w3'

@njgheorghita
Copy link
Contributor Author

@kclowes Correct me if I'm wrong, but I vaguely recall you were writing up some kind of testing script that could handle ^?

@kclowes
Copy link
Collaborator

kclowes commented Dec 18, 2019

Yep, its in #1545. I stole it from Trinity and I'm not 100% sure, it looks to me like it's designed to be run before a release, rather than automatically by the test suite. I'm waiting on confirmation to be sure I'm not missing something though.

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! :shipit:

@njgheorghita njgheorghita merged commit c1c80db into ethereum:master Dec 19, 2019
@njgheorghita njgheorghita deleted the typing-extensions branch December 19, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants