Add script to test packaging

[kclowes]

What was wrong?

We had a release (5.3.1) that was missing a dependency. Unfortunately, that wasn't caught until after the release.

Related to Issue #1540

How was it fixed?

I stole a script from trinity that installs the release to a temporary virtualenv for testing.

Todo:

• Add entry to the release notes
• Add this to CI (ex. https://github.com/ethereum/trinity/pull/106/files#diff-b91f3d5bd63fcd17221b267e851608e8R61-R64)

Cute Animal Picture

[kclowes]

@pipermerriam It looks like this script only builds from the wheel that is already in dist/. Does the Trinity team usually do a new local build and then run this script, or what is your preferred flow?

[pipermerriam]

cc @carver did you setup the wheel tests for trinity?

[veox]

@kclowes The dist is built as part of the *-wheel-cli CI jobs; here's the linked lines:

commands=
    /bin/rm -rf build dist
    python setup.py sdist bdist_wheel
    /bin/bash -c 'pip install --upgrade "$(ls dist/*.whl)""[p2p,trinity]" --progress-bar off'
    pytest {posargs:tests/integration/ -k 'trinity_cli' --log-cli-level 0}

(As you can see, it also runs a small selection of integration tests. Something like python -c 'from web3.auto import w3' could be used as a placeholder.)

It was first added in PR ethereum/trinity#106, and later modified.

[kclowes]

Aha! Thanks for looking into that @veox!

[pipermerriam]

Looks like this file might not have type hints enforced. I would recommend doing that ahead of this (or as part of it) so that you can ensure that all new code to the repo has type hints.

[pipermerriam]

Looks 👍

I'm not seeing anywhere that the test_package.py script is being invoked in CI am I missing something?

[kclowes]

Nope, good catch. Instead of adding to CI, I added to the Makefile and the README similar to what Trinity has going on. There is a smoke test in CI that makes sure that the wheel builds and that we can import web3 though.