Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification API 2 #342

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Verification API 2 #342

merged 1 commit into from
Jan 13, 2021

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Jan 4, 2021

View in Huly HI-1050

@FabijanC FabijanC changed the base branch from master to staging January 4, 2021 13:38
@FabijanC FabijanC marked this pull request as ready for review January 5, 2021 09:48
@FabijanC FabijanC requested a review from DeFiYaco January 5, 2021 09:53
@FabijanC FabijanC force-pushed the sessions branch 7 times, most recently from 0f7fe69 to c199816 Compare January 8, 2021 09:33
Copy link
Contributor

@DeFiYaco DeFiYaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look into this documentation https://express-validator.github.io/docs/
I think you can make these API endpoints cleaner by using this package. We are already using it in the FileController.ts.

Also, there are few TODO comments that I would like you to check out if you forgot about them. We can discuss them if you need help with something.

@FabijanC FabijanC force-pushed the sessions branch 2 times, most recently from 864e326 to 3c3b296 Compare January 13, 2021 08:35
@DeFiYaco DeFiYaco self-requested a review January 13, 2021 12:52
@FabijanC FabijanC merged commit 87bfe97 into staging Jan 13, 2021
@DeFiYaco DeFiYaco deleted the sessions branch May 24, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants