Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return different status for the already verified contract through /verify API endpoint #334

Closed
vbaranov opened this issue Dec 14, 2020 · 1 comment · Fixed by #342
Closed

Comments

@vbaranov
Copy link

vbaranov commented Dec 14, 2020

Currently, /verify API endpoint returns

{
    "result": [
        {
            "address": "0x...",
            "status": "perfect"
        }
    ]
}

even if someone tries to verify with wrong verification data already verified contract.

I suppose this API endpoint should return a different status, kinda "status": "already verified", in case of contract has been previously verified.

View in Huly HI-167

@DeFiYaco
Copy link
Contributor

That is correct. If the contract with the provided address is already verified and its sources are present in the repository, server will not recompile and recheck provided sources from the request.
I agree that this status "perfect" is misleading in this case. Thanks for your submission, we will make some changes after we discuss what is the best approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants