Skip to content

Commit

Permalink
Merge pull request #3949 from ethereum/prepareRelease
Browse files Browse the repository at this point in the history
Prepare 0.4.23 release.
  • Loading branch information
chriseth authored Apr 19, 2018
2 parents 2546a27 + a79c9a1 commit 3f72237
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
### 0.4.23 (unreleased)
### 0.4.23 (2018-04-19)

Features:
* Build system: Support Ubuntu Bionic.
Expand Down
8 changes: 8 additions & 0 deletions docs/bugs.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
[
{
"name": "OneOfTwoConstructorsSkipped",
"summary": "If a contract has both a new-style constructor (using the constructor keyword) and an old-style constructor (a function with the same name as the contract) at the same time, one of them will be ignored.",
"description": "If a contract has both a new-style constructor (using the constructor keyword) and an old-style constructor (a function with the same name as the contract) at the same time, one of them will be ignored. There will be a compiler warning about the old-style constructor, so contracts only using new-style constructors are fine.",
"introduced": "0.4.22",
"fixed": "0.4.23",
"severity": "very low"
},
{
"name": "ZeroFunctionSelector",
"summary": "It is possible to craft the name of a function such that it is executed instead of the fallback function in very specific circumstances.",
Expand Down
8 changes: 7 additions & 1 deletion docs/bugs_by_version.json
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,15 @@
"released": "2018-03-07"
},
"0.4.22": {
"bugs": [],
"bugs": [
"OneOfTwoConstructorsSkipped"
],
"released": "2018-04-16"
},
"0.4.23": {
"bugs": [],
"released": "2018-04-19"
},
"0.4.3": {
"bugs": [
"ZeroFunctionSelector",
Expand Down
8 changes: 4 additions & 4 deletions scripts/update_bugs_by_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ def comp(version_string):
continue
versions[v]['bugs'] += [bug['name']]

with open(path + '/../docs/bugs_by_version.json', 'r+') as bugs_by_version:
new_contents = json.dumps(versions, sort_keys=True, indent=4)
with open(path + '/../docs/bugs_by_version.json', 'r') as bugs_by_version:
old_contents = bugs_by_version.read()
new_contents = json.dumps(versions, sort_keys=True, indent=4)
bugs_by_version.seek(0)
with open(path + '/../docs/bugs_by_version.json', 'w') as bugs_by_version:
bugs_by_version.write(new_contents)
sys.exit(old_contents != new_contents)
sys.exit(old_contents != new_contents)

0 comments on commit 3f72237

Please sign in to comment.