Skip to content

Commit

Permalink
Merge pull request #3941 from ethereum/bytes-contract
Browse files Browse the repository at this point in the history
Disallow explicit conversion of bytesXX to contract
  • Loading branch information
chriseth authored Apr 19, 2018
2 parents 6f0fbcf + 754d79e commit 2546a27
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Bugfixes:
* Type Checker: Improve error message for failed function overload resolution.
* Type Checker: Do not complain about new-style constructor and fallback function to have the same name.
* Type Checker: Detect multiple constructor declarations in the new syntax and old syntax.
* Type Checker: Explicit conversion of ``bytesXX`` to ``contract`` is properly disallowed.

### 0.4.22 (2018-04-16)

Expand Down
1 change: 0 additions & 1 deletion libsolidity/ast/Types.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1299,7 +1299,6 @@ bool FixedBytesType::isExplicitlyConvertibleTo(Type const& _convertTo) const
{
return _convertTo.category() == Category::Integer ||
_convertTo.category() == Category::FixedPoint ||
_convertTo.category() == Category::Contract ||
_convertTo.category() == category();
}

Expand Down
7 changes: 7 additions & 0 deletions test/libsolidity/syntaxTests/types/bytes_to_contract.sol
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
contract C {
function f() public pure {
C(bytes20(0x1234));
}
}
// ----
// TypeError: (64-82): Explicit type conversion not allowed from "bytes20" to "contract C".

0 comments on commit 2546a27

Please sign in to comment.