Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port entry points to click cli; add tests #483

Merged
merged 15 commits into from
Apr 1, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Mar 20, 2024

🗒️ Description

  • Ports the scripts previously defined in src/entry_points to click and moves them to src/cli.
  • Adds tests for the order_fixtures and fill click commands.

If working in an existing EEST installation a reinstall is necessary:

pip install --force-reinstall -e .

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:feat type: Feature scope:fw Scope: Framework (evm|tools|forks|pytest) labels Mar 20, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, love this library!

Thanks.

@marioevz marioevz force-pushed the feat/use-click-for-entry-points branch from e444919 to c4a2121 Compare April 1, 2024 15:27
@marioevz
Copy link
Member

marioevz commented Apr 1, 2024

Rebased to the latest main and force pushed.

@marioevz marioevz merged commit c6a2d33 into ethereum:main Apr 1, 2024
5 checks passed
@marioevz marioevz mentioned this pull request Apr 1, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants