Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate test using debug_traceCall #470

Merged
merged 3 commits into from
Apr 1, 2024
Merged

generate test using debug_traceCall #470

merged 3 commits into from
Apr 1, 2024

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Mar 7, 2024

πŸ—’οΈ Description

Generate .py test using debug_traceCall to make a state test for transaction from mainnet by its hash

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Thanks for implementing this.

A few comments to improve it.

src/entry_points/gentest.py Outdated Show resolved Hide resolved
src/entry_points/gentest.py Outdated Show resolved Hide resolved
src/entry_points/gentest.py Outdated Show resolved Hide resolved
src/entry_points/gentest.py Outdated Show resolved Hide resolved
src/entry_points/gentest.py Outdated Show resolved Hide resolved
src/entry_points/gentest.py Outdated Show resolved Hide resolved
src/entry_points/gentest.py Outdated Show resolved Hide resolved
src/entry_points/gentest.py Outdated Show resolved Hide resolved
@winsvega
Copy link
Collaborator Author

winsvega commented Mar 8, 2024

Forgot the env.

Lets make it work with legacy txs before any optimizations.

@winsvega winsvega force-pushed the gentest branch 2 times, most recently from fe8a655 to 550125c Compare March 12, 2024 13:54
@marioevz
Copy link
Member

marioevz commented Apr 1, 2024

Updates:

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 5e64f50 into main Apr 1, 2024
9 checks passed
@marioevz marioevz deleted the gentest branch April 1, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants