This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a huge deal but just thought it was cleaner to have the orders be consistent :)
I was getting a warning about unused local variables and was unable to compile this code in the Ethereum Wallet app. This fixes that problem and (I think) still does everything else correctly.
* It was a bit confusing to hop into this tutorial right away without the context on (1) having installed geth and (2) the smart contract file type / compiler etc. * Couple of minor typos
Links to parity.io and parity.io/parity were outdated. Company renamed itself from Ethcore to Parity Technologies.
Without the `+`, the `balanceOf` mapping only keeps track of the last purchase an account makes. I.e, if an account participates in the crowdsale multiple times, the coin sale fails and an account asks for a refund, the account won't get all of its Ether back.
* gh-pages build * Update github pages (#288) * updated token * fix link from homepage * adds security issue to the token code * updates to the readme * Bump to 0.7.6 * update Bernd Lapp bio * typo * bump version to 8.1 * Separated Approve and Approve And Call * Updated README with GitHub pages instructions * Just like before (#284) removed an errant you * update to 0.8.2 and removes mix * Update Google Analytics tracking ID (#286) * Update Build 0.8.2 * added v to download link * update Ethereum Wallet links to 0.8.6 * added geth binaries * test file * removed binaries * added mist geth binaries * removed binaries * Timelock and payable daos * update to 0.8.8 * build * merge and build * Updated build * Update foundation.md * Update foundation.md * Update foundation.html * Update foundation.html * Update foundation.html * Update foundation.html * Update foundation.html * Update foundation.html * Removed link to the legal notice * updated build * Updated build (#602) * merge * megre and build * remove devcon1 content
To reflect current ethereum/homestead-guide#305 / The [cpp-ethereum documentation](http://www.ethdocs.org/en/latest/ethereum-clients/cpp-ethereum/index.html)
At this point in the tutorial it is likely that the reader does not have solidity installed, so it probably makes sense to link to where/how to install it. I've included one link I found but if there is a better link that could be included as well. It seems other parts of this page may be out of date but this sentence should help.
Ensure privacy, cookies and terms pages and built
Small grammatical fix
Replace 'if ... throw()' with 0.4.10 require() syntax
* add allowance update to burnFrom burnFrom method should also update sender's allowance. Otherwise, it can burn as much as it wants. * improved language as requested
I believe this has been superseded by #639 correct? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add the cookie-policy.html, privacy-policy.html, and terms-of-use.html files