This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
Replace 'if ... throw()' with 0.4.10 require() syntax #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clone1612
changed the title
|
Link to the relevant solidity changelog :) https://github.com/ethereum/solidity/blob/develop/Changelog.md#0410-2017-03-15 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for pull request
Solidity 0.4.10 introduced the
require()syntax which throws if the condition is false. The changes made in this PR are aimed at replacing theif ... throw()statements. This is done to encourage the behavior shown in the official Solidity documentation.Testing
All code compiles with 0.4.11
If there is anything wrong or something that needs to be improved/changed feel free to say so, this is my first pull request for this project so I'm not yet familiar with the exact workflow.