Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic trans #583

Merged
merged 9 commits into from
Nov 28, 2019
Merged

Arabic trans #583

merged 9 commits into from
Nov 28, 2019

Conversation

EmanHerawy
Copy link
Contributor

Description

Ethereum.org Site Translation: Arabic #541 following all the steps mentioned in this bounty https://ethscholars.bounties.network/bounty/3747

Related Issue

Solves Issue #541

Screenshots (if appropriate):

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Left one small comment but looks great overall. I'll merge this & make that update.

@@ -58,6 +58,7 @@ export default {
'Αιθέριο',
'Eterijum',
'إثيريوم',
'إثيريوم',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line? Let's remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that , I didn't expect it was already added. I have fixed it . I have to create new PR, Right ?

Suggested change
'إثيريوم',
'إثيريوم',

@samajammin samajammin merged commit ccdda4b into ethereum:dev Nov 28, 2019
@samajammin
Copy link
Member

@all-contributors please add @EmanHerawy for code

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @EmanHerawy! 🎉

@samajammin samajammin mentioned this pull request Nov 28, 2019
@samajammin
Copy link
Member

Hey @EmanHerawy - please head here to fulfill the work: https://ethscholars.bounties.network/bounty/3747

Once that's complete, we'll get this bounty paid out to you! Thanks again.

@EmanHerawy
Copy link
Contributor Author

@samajammin Thanks a lot. I have already fulfilled the bounty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants