Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dutch and Polish translations [fixes #357 #358] #375

Merged
merged 5 commits into from
Nov 6, 2019

Conversation

dantop114
Copy link
Contributor

Files structure follow the structure in PR #282

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @antodp! Thanks for this contribution.

A few small comments to address. Once those are resolved, this should be ready to merge 👍

Another request for future contributions - please isolate PRs to single issues (e.g. in this case, open up separate PRs for each translation). Thanks in advance!

docs/.vuepress/theme/utils/translations.js Outdated Show resolved Hide resolved
'page-learn': 'Info',
'page-developers': 'Ontwikkelaars',
},
'pl-PL': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same deal here - please update this key to match CrowdIn (pl - https://crowdin.com/project/ethereumfoundation/pl)

docs/nl/beginners/index.md Outdated Show resolved Hide resolved
docs/pl/index.md Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@dantop114
Copy link
Contributor Author

Okay, changes done!
Also I'm planning to make a PR to include RandomList component in translated pages.
Thank you for your attention!

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes! Great work 🎉

Hope you continue to contribute 😄

@samajammin samajammin merged commit d2b7e27 into ethereum:dev Nov 6, 2019
@samajammin samajammin mentioned this pull request Nov 6, 2019
4 tasks
@samajammin
Copy link
Member

@all-contributors please add @antodp for code

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @antodp! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants