-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker-targets v2 [revert previous revert, fix cross-build] [DRAFT] #8721
Conversation
…cker-targets"" This reverts commit d972c46. It also fixes up some conflicts / inconsistencies, since op-conductor was added after the original revert.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8721 +/- ##
===========================================
+ Coverage 34.53% 34.57% +0.04%
===========================================
Files 167 167
Lines 7170 7170
Branches 1213 1213
===========================================
+ Hits 2476 2479 +3
+ Misses 4544 4539 -5
- Partials 150 152 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Still want to fix this PR, but the cross-build issue (build for arm on x86) somehow persisted, something is wrong. Maybe the target build arg is not being set by docker buildx, and defaulting to empty? Or maybe it's an issue with Go build cache? |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Description
See #8568 for context.
TODO: review cross-platform build issue.
This PR:
Metadata
Fix #8568