Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-targets v2 [revert previous revert, fix cross-build] [DRAFT] #8721

Closed
wants to merge 2 commits into from

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented Dec 21, 2023

Description

See #8568 for context.

TODO: review cross-platform build issue.

This PR:

  • gets rid of the "op stack go" intermediate docker image
  • gets rid of tens of copy-paste dockerfiles
  • shares the docker build in a docker-file such that the Go mod/build-caching is shared
  • uses docker-targets to separate the different docker builds
  • organizes the docker targets with the bake file, so configuration is hosted in a way that is not specific to CI or custom make files
  • makes the bake file configure the build contexts
  • makes the bake file deal with platform target
  • makes the bake file deal with versioning through build args, to not depend on the full git history in the docker build
  • encourages docker buildx bake as the way to build, since it supports multi-platform images well

Metadata

Fix #8568

…cker-targets""

This reverts commit d972c46.

It also fixes up some conflicts / inconsistencies,
 since op-conductor was added after the original revert.
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.57%. Comparing base (c04cefe) to head (f084ac9).
Report is 761 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8721      +/-   ##
===========================================
+ Coverage    34.53%   34.57%   +0.04%     
===========================================
  Files          167      167              
  Lines         7170     7170              
  Branches      1213     1213              
===========================================
+ Hits          2476     2479       +3     
+ Misses        4544     4539       -5     
- Partials       150      152       +2     
Flag Coverage Δ
cannon-go-tests 63.48% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.74% <ø> (ø)
contracts-bedrock-tests 20.24% <ø> (+0.14%) ⬆️
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 42.18% <ø> (ø)
sdk-tests 42.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jan 5, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 5, 2024
@protolambda protolambda removed the Stale label Jan 5, 2024
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@protolambda
Copy link
Contributor Author

Still want to fix this PR, but the cross-build issue (build for arm on x86) somehow persisted, something is wrong. Maybe the target build arg is not being set by docker buildx, and defaulting to empty? Or maybe it's an issue with Go build cache?

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 7, 2024
@github-actions github-actions bot closed this Mar 12, 2024
@bitwiseguy bitwiseguy mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci/docker: revert the revert - docker build with targets (and now fix cross-platform builds)
1 participant