Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/docker: revert the revert - docker build with targets (and now fix cross-platform builds) #8568

Closed
protolambda opened this issue Dec 11, 2023 · 1 comment
Closed

ci/docker: revert the revert - docker build with targets (and now fix cross-platform builds) #8568

protolambda opened this issue Dec 11, 2023 · 1 comment
Assignees
@protolambda

Comments

@protolambda
Copy link
Contributor

We want to utilize the docker-target system and simplify the build by removing the monolithic intermediate Go op-stack image, while also still benefiting from layer-caching.

See original PR here: #8242

Building the arm docker image on x86 appeared to result in a malfunctioning arm image.

See incorrect hotfix that started building in emulated mode here: #8324

And see revert here: #8330
@protolambda protolambda self-assigned this Dec 11, 2023
@protolambda protolambda mentioned this issue Dec 21, 2023
Closed
@protolambda
Copy link
Contributor Author

This was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@protolambda protolambda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docker-targets v2 [revert previous revert, fix cross-build] [DRAFT] ethereum-optimism/optimism
1 participant
@protolambda