op-program: Support running in offline mode. #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review. |
ajsutton
force-pushed
the
aj/fpp-store-fetched-data
branch
from
09a1965 to
4739b0f
Compare
ajsutton
force-pushed
the
aj/fpp-disk-store
branch
from
214cf01 to
a12652d
Compare
|
Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review. |
ajsutton
force-pushed
the
aj/fpp-disk-store
branch
from
a12652d to
69cb291
Compare
✅ Deploy Preview for opstack-docs canceled.
|
ajsutton
force-pushed
the
aj/fpp-disk-store
branch
from
69cb291 to
3dfc570
Compare
Inphi
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the setup code for op-program to support running in offline mode. A
--datadirCLI arg is added to specify the directory to use to store preimage data. If the--l1and--l2options are specified the preimages are fetched, otherwise only the pre-populated preimages are used to replay the derivation.In-memory kv store is still supported in fetching mode if no
--datadiris supplied because it makes testing easier (and the host part of op-program is essentially just a test harness).Tests
Tests for the new CLI arg and config option. Will need to add e2e tests to cover the setup changes.
Additional context
Builds on #5463, #5465 and #5452
Metadata