You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a pre-fetcher that takes in the hints from HintReader.NextHint and request for preimages from OracleServer.NextPreimageRequest and then populates the KV store by fetching required data.
Modifies the op-program main to use this fetcher and an in-memory KV store as the backing for oracle requests. This makes the fetching mode run using the same key/value requests and access as non-fetching mode would just using hints to fetch the required data on demand.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Alternatively we could also add error-returns to the "fetching oracle" code, if there's functionality there that we want to share rather than plugging directly into a L1/L2 client from sources package. And then define wrappers in the client package that map an error-returning oracle to one that escalates them to critical errors.
Base automatically changed from
aj/fpp-test-stubs to
developApril 17, 2023 09:13
As per Slack discussion: updated the prefetcher to take an interface matching the L1/L2 rpc bindings (and added debug bindings for the MPT-node / code fetching). This way the prefetcher can handle errors and bubble them up to the get-preimage caller (who can then shut down the program from the host side etc.).
…e oracle
op-program now uses an in-memory key-value store as the backing for all data with the same key-based retrieval and deserialization as in non-fetching mode.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ajsutton
force-pushed
the
aj/fpp-store-fetched-data
branch
from
Description
Implements a pre-fetcher that takes in the hints from
HintReader.NextHintand request for preimages fromOracleServer.NextPreimageRequestand then populates the KV store by fetching required data.Modifies the op-program main to use this fetcher and an in-memory KV store as the backing for oracle requests. This makes the fetching mode run using the same key/value requests and access as non-fetching mode would just using hints to fetch the required data on demand.
Additional context
Builds on #5463 and #5465
Metadata