feat: Include MTCannon in OPCM upgrade #13930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maurelian
changed the title
maurelian
force-pushed
the
opcm-up/upgrade-asr
branch
5 times, most recently
from
5607ae4 to
d14c0c6
Compare
mds1
reviewed
Jan 25, 2025
Comment on lines
+174
to
+175
| /// @notice The prestate hash to be used for the upgrade. | ||
| bytes32 public immutable prestateHash; |
There was a problem hiding this comment.
Per @ajsutton, I think this should be an input per-chain, just to be safe? https://discord.com/channels/1244729134312198194/1332055053003001886/1332084289537441912
mds1
reviewed
Jan 25, 2025
| @@ -109,7 +109,7 @@ contract OPContractsManager is ISemver { | |||
| address disputeGameFactoryImpl; | |||
| address anchorStateRegistryImpl; | |||
| address delayedWETHImpl; | |||
| address mipsImpl; | |||
| address mips64Impl; | |||
There was a problem hiding this comment.
MIPS is a singleton for all chains, so putting it in this struct feels a bit misleading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A strawman PR to demonstrate my understanding of the MTCannon upgrade path.
Important details:
absolutePrestatetaken from releases.json