feat: Add upgrade of superchain singletons #13814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13814 +/- ##
===========================================
- Coverage 46.67% 45.38% -1.30%
===========================================
Files 973 916 -57
Lines 81444 76782 -4662
Branches 756 757 +1
===========================================
- Hits 38015 34845 -3170
+ Misses 40471 39152 -1319
+ Partials 2958 2785 -173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
maurelian
force-pushed
the
opcm-up/upgrade-asr
branch
from
ad84635 to
b633209
Compare
maurelian
force-pushed
the
opcm-up/superchain-singletons
branch
from
a943dc7 to
6a8bc7b
Compare
maurelian
force-pushed
the
opcm-up/upgrade-asr
branch
from
b633209 to
c16b824
Compare
maurelian
requested review from
zhwrd and
protolambda
and removed request for
a team
maurelian
force-pushed
the
opcm-up/upgrade-asr
branch
from
c16b824 to
ba91c25
Compare
maurelian
force-pushed
the
opcm-up/superchain-singletons
branch
from
6a8bc7b to
3a1e775
Compare
maurelian
force-pushed
the
opcm-up/upgrade-asr
branch
2 times, most recently
from
96ed2e1 to
0e8e8dd
Compare
maurelian
force-pushed
the
opcm-up/superchain-singletons
branch
from
3a1e775 to
2425249
Compare
maurelian
force-pushed
the
opcm-up/upgrade-asr
branch
from
0e8e8dd to
cdf0556
Compare
maurelian
force-pushed
the
opcm-up/superchain-singletons
branch
from
2425249 to
33a9849
Compare
maurelian
force-pushed
the
opcm-up/upgrade-asr
branch
2 times, most recently
from
32b4bfe to
ee640d2
Compare
maurelian
force-pushed
the
opcm-up/superchain-singletons
branch
from
9a77caf to
08bb8a1
Compare
maurelian
force-pushed
the
opcm-up/superchain-singletons
branch
from
21cfde9 to
7266b01
Compare
mds1
approved these changes
Jan 25, 2025
This was referenced Jan 27, 2025
samlaf
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jan 27, 2025
* feat: Add upgrade of superchain singletons * feat: assert on sc upgrade * feat: update snapshots * feat: dedupe .anchorStateRegistry() calls save 170 bytes * Fix IOpcm Implementations struct * fix: view visibility on getAnchorStateRegistry() * fix: use internal visibility on library func for DeploySuperchainImplementations * fix: use correct SuperchainConfigProxy name for address retrieval * fix: use correct SuperchainConfigProxy name for address retrieval * snapshots * fix: remove superchain contracts from DII * feat: use 1967Helper to get sc impls * fix: sc and pv names * fix: sc contracts on dio * feat: undeduplicate deploySuperchainImplementations * feat: fix DeployOPCM tests * wip * fix: IOPCM iface * feat: Add only owner revert tests * lint * bump semver * ci fixes * fix: OPCMInterop semver * feat: Add SCC and PV to go structs in opd * fix: Add SC and PV impls to interopgen * go lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for upgrading
SuperchainConfigandProtocolVersionscontracts through the OPContractsManager.What changed?
superchainConfigImplandprotocolVersionsImplto the OPContractsManager's Implementations struct. This also requires adding those values toDeploySuperchain,DeployImplementationsandDeployOPCM.upgradefunction in OPContractsManager to handle upgrading superchain contracts.