add etcd watch design documentation #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 this should be a good beginning of watch. |
| @@ -0,0 +1,88 @@ | |||
| # Overview | |||
|
|
|||
| The EtcdWatch provide methods to watch on a key and cancel a watcher, if the watcher is disconnected on error, it will be resumed automatically. | |||
There was a problem hiding this comment.
"cancel a watcher. If ..."
Use "."
|
@StupidHod @adohe |
|
@hongchaodeng yes, we should examine the goals before we start the implementation. |
StupidHod
force-pushed
the
watch
branch
5 times, most recently
from
91f6699 to
f6e9dea
Compare
Closed
StupidHod
force-pushed
the
watch
branch
3 times, most recently
from
23c28d6 to
3e8d91e
Compare
|
@StupidHod So this works pretty similar to the go version? |
| @@ -0,0 +1,110 @@ | |||
| # Overview | |||
|
|
|||
| The EtcdWatch provide methods to watch on a key and cancel a watcher. If the watcher is disconnected on error, it will be resumed automatically. | |||
|
The design doc looks good. Let's clean it up and get it merged. |
|
@xiang90 , thanks for your advice, I have cleared it up with your tips. |
| @@ -0,0 +1,110 @@ | |||
| # Overview | |||
There was a problem hiding this comment.
replace all Etcd with etcd (including file name)
|
Ok, I have corrected it. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope for your advice, @xiang90 @adohe