Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss watch client #42

Closed
StupidHod opened this issue Aug 24, 2016 · 9 comments
Closed

discuss watch client #42

StupidHod opened this issue Aug 24, 2016 · 9 comments

Comments

@StupidHod
Copy link
Contributor

Hi, as discussed in PR #40 , we should discuss about the goals of etcd watch client.

As my idea, etcd watch is a client to manage watch requests.
Goals:

  1. Request watch operation, watch client create watch request for client with key, option(revision, delete only, put only and end key) and register callback for watch request.
  2. Notification, when watch client receive event from etcd server, it will call registered callback.
  3. Resume, when the watch client disconnect with etcd server, it will automatically resume all the watch requests and get notification from the latest received revision.
  4. Cancel watch request, the etcd client shound cancel watch request when client request and filter all the notification after user request canceled.

Hope for your ideas about watch client, @hongchaodeng @sijie @xiang90 @adohe .

@StupidHod StupidHod changed the title discuss watch function discuss watch client Aug 24, 2016
@hongchaodeng
Copy link
Contributor

I agree with above statements.

The goals we want should be more explicit. Specifically, we want to talk about what we want instead of coding details like methods, instances in #40 .

@StupidHod
Copy link
Contributor Author

Ok, got your advice, so I should add above statements to etcd watch design document.

@lamuguo
Copy link

lamuguo commented Nov 8, 2016

What's the status of this one?

@krestenkrab
Copy link

Hi. What's the status of the watch client? jetcd is not usable without watches?...

@heyitsanthony
Copy link
Contributor

/cc @fanminshi

@fanminshi
Copy link
Member

@krestenkrab, The watch implementation is still in pr #45. I will try to get it merged starting Q2; Expect a full speed development on jetcd in Q2.

@lamuguo
Copy link

lamuguo commented Mar 14, 2017 via email

@StupidHod
Copy link
Contributor Author

@lamuguo OK, please ping me with no hesitation.

@xiang90
Copy link
Contributor

xiang90 commented Apr 27, 2017

watcher is implemented

@xiang90 xiang90 closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

7 participants