migrate to use max-learners flag

[gangli113]

Migrate flag experimental-max-learners described in: #19141

The experimental flags are marked as deprecated and will be decommissioned in v3.7

[k8s-ci-robot]

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.87%. Comparing base (35d20d1) to head (27d9978).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
server/etcdserver/bootstrap.go	71.42%	1 Missing and 1 partial ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
server/config/config.go	80.23% <ø> (ø)
server/embed/config.go	79.65% <100.00%> (+0.06%)	⬆️
server/embed/etcd.go	76.49% <100.00%> (ø)
server/etcdmain/config.go	73.17% <100.00%> (+0.33%)	⬆️
server/etcdserver/bootstrap.go	63.59% <71.42%> (ø)

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19298      +/-   ##
==========================================
+ Coverage   68.84%   68.87%   +0.03%     
==========================================
  Files         420      420              
  Lines       35689    35693       +4     
==========================================
+ Hits        24570    24584      +14     
+ Misses       9693     9691       -2     
+ Partials     1426     1418       -8     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d20d1...27d9978. Read the comment docs.

[gangli113]

/cc @siyuanfoundation @serathius @ahrtr

[ahrtr]

/ok-to-test

[k8s-ci-robot]

@gangli113: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-release-tests	27d9978	link	false	/test pull-etcd-release-tests

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ahrtr]

Please resolve the workflow failures, thx

[ahrtr]

@ivanvc @jmhbnz It looks like the workflow failure in pull-etcd-release-tests isn't caused by this PR. Could you please take a look?

I see that other PRs also fails.

[ivanvc]

@ivanvc @jmhbnz It looks like the workflow failure in pull-etcd-release-tests isn't caused by this PR. Could you please take a look?

I see that other PRs also fails.

I'm working on it. Yesterday the PR that enabled it was merged after I took off. It's marked as optional as it's still WIP. I'll remove the always run option to avoid flooding

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, gangli113, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment