Migrate non-boolean experimental flags in 3.6

[siyuanfoundation]

What would you like to be added?

For the 3.6 release, we would like to have the list of non-boolean --experimental flags migrated to flags without the --experimental prefix.

• experimental-corrupt-check-time: migrate flag experimental-corrupt-check-time to use corrupt-check-time #19156
• experimental-compaction-batch-limit: migrate flag experimental-compaction-batch-limit to use compaction-batch-limit #19196
• experimental-watch-progress-notify-interval: migrate flag experimental-watch-progress-notify-interval to use watch-progress-notify-interval #19248
• experimental-warning-apply-duration: migrate to use warning-apply-duration flag #19264
• experimental-bootstrap-defrag-threshold-megabytes: migrate to use bootstrap-defrag-threshold-megabytes flag #19267
• experimental-warning-unary-request-duration
• experimental-max-learners
• experimental-snapshot-catch-up-entries
• experimental-compaction-sleep-interval
• experimental-downgrade-check-time
• experimental-set-member-localaddr

In 3.6, we would like to have both the flags with and without the --experimental prefix working. experimentalNonBoolFlagMigrationMap should be used to achieve that. #19156 is an example.

Why is this needed?

flag clean up for release 3.6

[siyuanfoundation]

@ahrtr @serathius Please double check the flag list and see if any flag needs to remain --experimental or missing any.

[siyuanfoundation]

/cc @gangli113

[gangli113]

/assign

[siyuanfoundation]

/reopen
because there are still other flags to migrate.

[ahrtr]

More contributors are welcome to work on this to accelerate it.

[ajaysundark]

I can take a look at some -

randomly self-assigning half of the set

experimental-snapshot-catch-up-entries
experimental-compaction-sleep-interval
experimental-downgrade-check-time
experimental-set-member-localaddr

/assign

[ajaysundark]

From community meeting, the ask here is not to 'graduate' the flags. But experimental nature of the feature to be descriptive in a way that's non-blocking, instead of having to rename the flag breaking the users during graduation.

cc: @serathius @ahrtr @siyuanfoundation

[ahrtr]

From community meeting, the ask here is not to 'graduate' the flags. But experimental nature of the feature to be descriptive in a way that's non-blocking, instead of having to rename the flag breaking the users during graduation.

cc: @serathius @ahrtr @siyuanfoundation

Yes, we are NOT graduating or deprecating any flags in this effort ( which is a separate effort). We are just changing the way to manage these experimental flags for now.

[gangli113]

@siyuanfoundation Seems the 6th flag, experimental-warning-unary-request-duration, has already been migrated

etcd/server/embed/config.go

Lines 418 to 422 in 35d20d1

	// WarningUnaryRequestDuration is the time duration after which a warning is generated if applying
	// unary request takes more time than this value.
	WarningUnaryRequestDuration time.Duration `json:"warning-unary-request-duration"`
	// ExperimentalWarningUnaryRequestDuration is deprecated, please use WarningUnaryRequestDuration instead.
	ExperimentalWarningUnaryRequestDuration time.Duration `json:"experimental-warning-unary-request-duration"`

[siyuanfoundation]

[@siyuanfoundation](https://github.com/siyuanfoundation) Seems the 6th flag, experimental-warning-unary-request-duration, has already been migrated

Removed, thanks!