make: fix running fix target after verify #17937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a Python virtual environment to install yamllint, if not installed locally, in a temporary directory and delete it after the run of the verify-yamllint command. This avoids the issue of building the build of materials that doesn't follow symlinks in the virtual environment directory. Signed-off-by: Ivan Valdes <[email protected]>
|
/retest |
|
/cc @jmhbnz |
ahrtr
approved these changes
May 4, 2024
jmhbnz
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a Python virtual environment to install
yamllint, if not installed locally, in a temporary directory and delete it after the run of theverify-yamllintcommand. This avoids the issue of building the build of materials that doesn't follow symlinks in the virtual environment directory.Fixes #17936.
Related to:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.