Merge pull request #17937 from ivanvc/fix-running-make-fix

make: fix running fix target after verify
etcd-io · May 5, 2024 · a8c6a9c · a8c6a9c
2 parents 301c74c + 0c134dd
commit a8c6a9c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -125,9 +125,11 @@ verify-genproto:
 verify-yamllint:
 ifeq (, $(shell which yamllint))
 	@echo "Installing yamllint..."
-	python3 -m venv bin/python
-	bin/python/bin/python3 -m pip install yamllint
-	./bin/python/bin/yamllint --config-file tools/.yamllint .
+	tmpdir=$$(mktemp -d); \
+	trap "rm -rf $$tmpdir" EXIT; \
+	python3 -m venv $$tmpdir; \
+	$$tmpdir/bin/python3 -m pip install yamllint; \
+	$$tmpdir/bin/yamllint --config-file tools/.yamllint .
 else
 	@echo "yamllint already installed..."
 	yamllint --config-file tools/.yamllint .