tests/framework/integration: Fail BeforeTest nesting early #13807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI failure is unrelated, but this will fail until a couple of my other open PRs are merged. (Re-running the full suite locally now with this commit to find more cases before folks hit the magical run button here too) |
[tests(dani/before-test-fix)] $ cat test.out | grep FAIL
=== FAIL: integration/clientv3 TestWatchCancelRunning (0.10s)
=== FAIL: integration/clientv3/experimental/recipes TestMutexTryLockSingleNode (0.08s)
=== FAIL: integration/clientv3/experimental/recipes TestMutexTryLockMultiNode (0.09s)Looks like #13806 and #13804 should resolve all of the current integration cases of this particular issue 🎉 |
|
@endocrimes feel free to ignore any semaphoreci test failures. On main branch we don't use it as a signal due to docker pull failures. We are planning to remove it #13448, however release-3.3 branch has no other tests. |
Currently there are a handful of tests within etcd that silently fail because LeakDetection will skip the test before it manages to hit this check. Here we move the check to the beginning of the process to highlight these cases earlier, and to avoid them accidentally presenting as leaks.
endocrimes
force-pushed
the
dani/before-test-fix
branch
from
fa828b0 to
7cc00ec
Compare
|
@serathius done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are a handful of tests within etcd that silently fail because LeakDetection will skip the test before it manages to hit this check.
Here we move the check to the beginning of the process to highlight these cases earlier, and to avoid them accidentally presenting as leaks.