Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration/client/watch.TestWatchCancelRunning: remove duplicate setup #13804

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

endocrimes
Copy link
Contributor

TestWatchCancelRunning was being skipped as it has a duplicate call to integration2.BeginTest. This duplicate call registered a second handler for leak detection which failed and skipped the test as the wrapper (runWatchTest) has already started a cluster.

part of #13698

Validation that all watch tests now (at least don't continuously) get skipped:

(gotestsum would print DONE 1 tests, 1 skipped in 1.417s if a test was skipped)

go test ./integration/... --list '.' | grep TestWatch | xargs -I '{}' sh -c 'echo {} && gotestsum -- ./integration/... --run ^{}$ --count=2 | grep DONE' | tee test.out
TestWatchWithProgressNotify                                                                                                                                                                                                                                                       
DONE 4 tests in 9.551s                                                                                                                                                                                                                                                            
TestWatchFragmentDisable                                                                                                                                                                                                                                                          
DONE 2 tests in 1.228s                                                                                                                                                                                                                                                            
TestWatchFragmentDisableWithGRPCLimit                                                                                                                                                                                                                                             
DONE 2 tests in 1.250s                                                                                                                                                                                                                                                            
TestWatchFragmentEnable                                                                                                                                                                                                                                                           
DONE 2 tests in 1.163s                                                                                                                                                                                                                                                            
TestWatchFragmentEnableWithGRPCLimit                                                                                                                                                                                                                                              
DONE 2 tests in 1.258s                                                                                                                                                                                                                                                            
TestWatchMultiWatcher                                                                                                                                                                                                                                                             
DONE 2 tests in 3.089s                                                                                                                                                                                                                                                            
TestWatchRange                                                                                                                                                                                                                                                                    
DONE 2 tests in 1.071s                                                                                                                                                                                                                                                            
TestWatchReconnRequest                                                                                                                                                                                                                                                            
DONE 2 tests in 6.522s                                                                                                                                                                                                                                                            
TestWatchReconnInit                                                                                                                                                                                                                                                               
DONE 2 tests in 1.185s                                                                                                                                                                                                                                                            
TestWatchReconnRunning                                                                                                                                                                                                                                                            
DONE 2 tests in 1.162s                                                                                                                                                                                                                                                            
TestWatchCancelImmediate                                                                                                                                                                                                                                                          
DONE 2 tests in 1.088s                                                                                                                                                                                                                                                            
TestWatchCancelInit                                                                                                                                                                                                                                                               
DONE 2 tests in 1.071s                                                                                                                                                                                                                                                            
TestWatchCancelRunning                                                                                                                                                                                                                                                            
DONE 2 tests in 1.094s                                                                                                                                                                                                                                                              
TestWatchResumeInitRev                                                                                                                                                                                                                                                            
DONE 2 tests in 1.283s                                                                                                                                                                                                                                                            
TestWatchResumeCompacted                                                                                                                                                                                                                                                          
DONE 2 tests in 3.123s                                                                                                                                                                                                                                                            
TestWatchCompactRevision                                                                                                                                                                                                                                                          
DONE 2 tests in 1.176s                                                                                                                                                                                                                                                            
TestWatchWithProgressNotify                                                                                                                                                                                                                                                       
DONE 4 tests in 9.598s                                                                                                                                                                                                                                                            
TestWatchWithProgressNotifyNoEvent                                                                                                                                                                                                                                                
DONE 2 tests in 13.618s                                                                                                                                                                                                                                                           
TestWatchRequestProgress                                                                                                                                                                                                                                                          
DONE 8 tests in 1.420s                                                                                                                                                                                                                                                            
TestWatchEventType                                                                                                                                                                                                                                                                
DONE 2 tests in 3.870s                                                                                                                                                                                                                                                            
TestWatchErrConnClosed                                                                                                                                                                                                                                                            
DONE 2 tests in 1.023s                                                                                                                                                                                                                                                            
TestWatchAfterClose                                                                                                                                                                                                                                                               
DONE 2 tests in 0.966s                                                                                                                                                                                                                                                            
TestWatchWithRequireLeader                                                                                                                                                                                                                                                        
DONE 2 tests in 2.107s                                                                                                                                                                                                                                                            
TestWatchWithFilter                                                                                                                                                                                                                                                               
DONE 2 tests in 1.207s                                                                                                                                                                                                                                                            
TestWatchWithCreatedNotification                                                                                                                                                                                                                                                  
DONE 2 tests in 0.954s                                                                                                                                                                                                                                                            
TestWatchWithCreatedNotificationDropConn                                                                                                                                                                                                                                          
DONE 2 tests in 3.044s                                                                                                                                                                                                                                                            
TestWatchCancelOnServer                                                                                                                                                                                                                                                           
DONE 2 tests in 3.044s                                                                                                                                                                                                                                                            
TestWatchOverlapContextCancel                                                                                                                                                                                                                                                     
DONE 2 tests in 3.686s                                                                                                                                                                                                                                                            
TestWatchOverlapDropConnContextCancel                                                                                                                                                                                                                                             
DONE 2 tests in 3.423s                                                                                                                                                                                                                                                            
TestWatchCancelAndCloseClient                                                                                                                                                                                                                                                     
DONE 2 tests in 1.071s                                                                                                                                                                                                                                                            
TestWatchStressResumeClose                                                                                                                                                                                                                                                        
DONE 2 tests in 1.196s                                                                                                                                                                                                                                                            
TestWatchCancelDisconnected                                         
DONE 2 tests in 5.015s                                              
TestWatchClose                                                      
DONE 2 tests in 1.055s          

This test was being skipped as it has a duplicate call to
integration2.BeginTest. This duplicate call registered a second handler
for leak detection which failed and skipped the test as the wrapper
(runWatchTest) has already started a cluster.
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

FYI in case you are interested. we are migrating the test at the moment, see etcd/issues/13637.

Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants